FileTargetDefinitionContent: Improve exception message #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve exception message when BundlesAction.createBundleArtifactKey(...) fails with the below stack trace, to at least know which .jar file couldn't be read. [ERROR] Could not resolve content of rcp.target [ERROR] org.eclipse.core.runtime.AssertionFailedException: null argument: [ERROR] at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:88) [ERROR] at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:76) [ERROR] at org.eclipse.equinox.internal.p2.metadata.ArtifactKey.<init>(ArtifactKey.java:79) [ERROR] at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.createBundleArtifactKey(BundlesAction.java:134) [ERROR] at org.eclipse.tycho.p2.resolver.FileTargetDefinitionContent.readBundles(FileTargetDefinitionContent.java:167) [ERROR] at org.eclipse.tycho.p2.resolver.FileTargetDefinitionContent.preload(FileTargetDefinitionContent.java:89) [ERROR] at org.eclipse.tycho.p2.resolver.FileTargetDefinitionContent.query(FileTargetDefinitionContent.java:73) [ERROR] at org.eclipse.tycho.p2.target.TargetDefinitionResolver.resolveContentWithExceptions(TargetDefinitionResolver.java:170) [ERROR] at org.eclipse.tycho.p2.target.TargetDefinitionResolver.resolveContent(TargetDefinitionResolver.java:110) [ERROR] at org.eclipse.tycho.p2.target.TargetDefinitionResolverService.resolveFromArguments(TargetDefinitionResolverService.java:86) [ERROR] at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) [ERROR] at org.eclipse.tycho.p2.target.TargetDefinitionResolverService.getTargetDefinitionContent(TargetDefinitionResolverService.java:59) [ERROR] at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.resolveTargetDefinitions(TargetPlatformFactoryImpl.java:209) [ERROR] at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform(TargetPlatformFactoryImpl.java:161) [ERROR] at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform(TargetPlatformFactoryImpl.java:134) [ERROR] at org.eclipse.tycho.p2.resolver.P2ResolverImpl.resolveMetadata(P2ResolverImpl.java:174) [ERROR] at org.eclipse.tycho.extras.tpvalidator.TPValidationMojo.validateTarget(TPValidationMojo.java:223) [ERROR] at org.eclipse.tycho.extras.tpvalidator.TPValidationMojo.execute(TPValidationMojo.java:152) [ERROR] at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
laeubi
approved these changes
Aug 23, 2023
|
@cedric780 can you please make sure that you sign the ECA? |
laeubi
added
the
backport-to-tycho-4.0.x
Done, I updated the ECA . |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve exception message when BundlesAction.createBundleArtifactKey(...) fails with the below stack trace, to at least know which .jar file couldn't be read.
Stack trace made with tycho 4.0.0 .